-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC break] Keep Guzzle v6 in v2 #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting failed (1161 errors).
(1149 notices occurred in your codebase, but were on files/lines not included in this PR.)
Are your other plugin installed via composer too? Or do they bundle Guzzle v6? |
The same way as S3-Uploads: it bundles Guzzle v6 installed with composer |
Maybe it should be a separate build with guzzle-v6? Like manual-install-guzzle-v6.zip? |
If they’re installed via composer it should be able figure out a compatible set of packages. What happens if you add guzzle v6 as a requirement in your main composer file? |
I don't have composer.json on the project level. The plugin zip files are downloaded and extracted, and that's it. So every plugin has its own |
Ah I see. Yeah that makes things difficult. You have a couple of options but I'd recommend reading through this primer https://composer.rarst.net/ At the simplest level you can use a |
Close as old |
This plugin is bundled with
aws-sdk-php
which requiresguzzlehttp/guzzle:^5.3.3|^6.2.1|^7.0
.In version 2.2.1 there was
guzzlehttp/guzzle:6.5.5
.But in 2.3.0 it's now
guzzlehttp/guzzle:7.2.0
.I have other plugins that require guzzle v6 and they crashed after the update to v2.3.0.
Since in PHP it's not possible to have 2 classes loaded of a different version, because if the class is already loaded it will not load it twice.
Please downgrade the guzzle version, at least in v2.